Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for https_proxy settings #531

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

jgallucci32
Copy link
Contributor

Add support for CEF installer to detect if HTTP proxy settings are configured for installations without direct internet connections.

Fixes cef_installer.py to allow for installation using https proxy

Proposed Changes

  • Import 'os' module into cef_installer.py
  • Detect presence of https_proxy environment variable
  • Add -p flag to omsagent install script if proxy variable present

Add support for CEF installer to detect if HTTP proxy settings are configured for installations without direct internet connections.
@Ronmarsiano
Copy link
Contributor

Thanks for the contribution, we are taking a look and will address the issue

@morshabi
Copy link
Contributor

Hi @jgallucci32,
Can you please share more info about the need for HTTP proxy scenario?

@morshabi morshabi merged commit 9c91fd0 into Azure:master Sep 16, 2020
@NoamLandress
Copy link
Contributor

Thank you for your contribution, we added this new functionality to our project.

@Ronmarsiano Ronmarsiano removed their assignment Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants