Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Download button not present on file viewer #1864

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

timotheeguerin
Copy link
Member

fix #1861

@timotheeguerin timotheeguerin changed the base branch from master to stable January 15, 2019 18:45
@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #1864 into stable will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #1864      +/-   ##
==========================================
+ Coverage   61.62%   61.63%   +<.01%     
==========================================
  Files         970      970              
  Lines       26457    26457              
  Branches     4846     4846              
==========================================
+ Hits        16305    16306       +1     
+ Misses      10115    10114       -1     
  Partials       37       37
Impacted Files Coverage Δ
...iewer-container/file-viewer-container.component.ts 84.21% <0%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c2612...6f203d9. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 4d24919 into stable Jan 15, 2019
@timotheeguerin timotheeguerin deleted the fix/file-viewer-download branch January 15, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant