Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Migrate bunyan -> winston #1871

Merged
merged 5 commits into from
Jan 17, 2019
Merged

Conversation

timotheeguerin
Copy link
Member

fix #1865

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #1871 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1871      +/-   ##
==========================================
+ Coverage   61.95%   61.98%   +0.02%     
==========================================
  Files         987      989       +2     
  Lines       26947    26962      +15     
  Branches     4956     4956              
==========================================
+ Hits        16695    16712      +17     
+ Misses      10215    10213       -2     
  Partials       37       37
Impacted Files Coverage Δ
src/client/main-window/main-window.ts 22.38% <ø> (-0.81%) ⬇️
src/common/constants/constants.ts 100% <ø> (ø) ⬆️
src/@batch-flask/utils/logging/test-logger.ts 50% <0%> (ø) ⬆️
src/@batch-flask/utils/logging/index.ts 62.5% <0%> (+6.94%) ⬆️
...ch-flask/utils/logging/renderer/renderer-logger.ts 100% <100%> (ø)
src/@batch-flask/utils/logging/configuration.ts 14.28% <14.28%> (ø)
src/@batch-flask/utils/logging/node-logger.ts 55.55% <71.42%> (+16.42%) ⬆️
src/client/logger/loggers.ts 90% <83.33%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7f8eb...3ce416e. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 8ce3d6c into master Jan 17, 2019
@timotheeguerin timotheeguerin deleted the internal/migrate-winston branch January 17, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from bunyan to winston for logging
1 participant