Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: subscription with nextLink undefined error and fix duplicate calls #1873

Merged
merged 3 commits into from
Jan 17, 2019

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jan 17, 2019

fix #1872

When listing subscription if the call add a nextLink to follow it was not returning which caused a undefined error

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #1873 into stable will increase coverage by 0.36%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #1873      +/-   ##
==========================================
+ Coverage   61.64%   62.01%   +0.36%     
==========================================
  Files         970      970              
  Lines       26481    26483       +2     
  Branches     4848     4848              
==========================================
+ Hits        16325    16423      +98     
+ Misses      10118    10022      -96     
  Partials       38       38
Impacted Files Coverage Δ
...pp/services/batch-account/batch-account.service.ts 63.39% <ø> (ø) ⬆️
...ervices/batch-account/arm-batch-account.service.ts 43.87% <ø> (ø) ⬆️
src/app/services/storage-account.service.ts 9.09% <ø> (ø) ⬆️
src/app/services/compute.service.ts 23.07% <ø> (ø) ⬆️
...ount/browse/account-list/account-list.component.ts 78.04% <0%> (ø) ⬆️
.../app/services/subscription/subscription.service.ts 67.64% <100%> (ø)
src/app/models/tenant-details.ts 100% <0%> (+40%) ⬆️
src/app/services/azure-http.service.ts 51.42% <0%> (+45.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b7b78...60771d3. Read the comment docs.

@timotheeguerin timotheeguerin changed the title Fix: subscription with nextLink undefined error Fix: subscription with nextLink undefined error and fix duplicate calls Jan 17, 2019
@timotheeguerin timotheeguerin merged commit 48b7930 into stable Jan 17, 2019
@timotheeguerin timotheeguerin deleted the fix/subscriptions-follow-nextlink branch January 17, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant