Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account monitoring charts to have different aggregation type #1880

Merged
merged 5 commits into from
Jan 22, 2019

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jan 22, 2019

  • Sum for events count
  • Avg for metrics
    image

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #1880 into master will increase coverage by 0.06%.
The diff coverage is 76.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1880      +/-   ##
=========================================
+ Coverage   62.84%   62.9%   +0.06%     
=========================================
  Files         991     992       +1     
  Lines       27039   27170     +131     
  Branches     4975    5004      +29     
=========================================
+ Hits        16992   17092     +100     
- Misses      10009   10040      +31     
  Partials       38      38
Impacted Files Coverage Δ
.../services/monitoring/metrics/core-count-metrics.ts 0% <ø> (ø) ⬆️
...services/monitoring/metrics/task-states-metrics.ts 100% <ø> (ø) ⬆️
...services/monitoring/metrics/node-states-metrics.ts 100% <ø> (ø) ⬆️
...services/monitoring/metrics/failed-task-metrics.ts 0% <ø> (ø) ⬆️
.../app/components/node/browse/node-list.component.ts 21.21% <0%> (-0.67%) ⬇️
...nents/task/details/task-sub-tasks-tab.component.ts 15.78% <0%> (-0.43%) ⬇️
.../app/components/task/browse/task-list.component.ts 11.66% <0%> (-0.2%) ⬇️
...ount/browse/account-list/account-list.component.ts 78.57% <100%> (+0.52%) ⬆️
...ervices/monitoring/metrics/monitor-metrics-base.ts 92.15% <100%> (ø) ⬆️
...s/certificate/browse/certificate-list.component.ts 72.41% <100%> (+0.98%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fc573...7c2df06. Read the comment docs.

@timotheeguerin timotheeguerin merged commit bda8aa4 into master Jan 22, 2019
@timotheeguerin timotheeguerin deleted the feature/tweak-account-monitor branch January 22, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant