Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dont use electron-builder zip functionlity on OSX as it corrupt the zip #1899

Merged
merged 14 commits into from
Feb 6, 2019

Conversation

timotheeguerin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #1899 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1899   +/-   ##
=======================================
  Coverage   64.16%   64.16%           
=======================================
  Files        1006     1006           
  Lines       27591    27591           
  Branches     5043     5043           
=======================================
  Hits        17703    17703           
  Misses       9850     9850           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28fa4f...e6d6f55. Read the comment docs.

@timotheeguerin timotheeguerin changed the title Fix: Pin electronbuilder dependency as it corrupt osx zip file Fix: Dont use electron-builder zip functionlity on OSX as it corrupt the zip Feb 6, 2019
@timotheeguerin timotheeguerin merged commit b529440 into master Feb 6, 2019
@timotheeguerin timotheeguerin deleted the fix/electron-builder-osx branch February 6, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant