Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show file group upload progress #1901

Merged
merged 3 commits into from
Feb 6, 2019

Conversation

timotheeguerin
Copy link
Member

fix #775
image

@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #1901 into master will increase coverage by <.01%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1901      +/-   ##
==========================================
+ Coverage   64.15%   64.16%   +<.01%     
==========================================
  Files        1006     1006              
  Lines       27566    27591      +25     
  Branches     5039     5043       +4     
==========================================
+ Hits        17686    17703      +17     
- Misses       9842     9850       +8     
  Partials       38       38
Impacted Files Coverage Δ
...ata/action/add/file-group-create-form.component.ts 10.89% <0%> (-0.34%) ⬇️
...d/file-group-picker/file-group-picker.component.ts 74.35% <78.57%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1cd42f...ba85989. Read the comment docs.

@timotheeguerin timotheeguerin merged commit b28fa4f into master Feb 6, 2019
@timotheeguerin timotheeguerin deleted the feature/show-file-group-upload branch February 6, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show upload progress under form control when creating file group
1 participant