Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show abssolute path and open actual file in local templates #1945

Merged
merged 6 commits into from
Mar 7, 2019

Conversation

timotheeguerin
Copy link
Member

fix #1944
fix #1943

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #1945 into master will increase coverage by <.01%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
+ Coverage   64.52%   64.53%   +<.01%     
==========================================
  Files        1009     1009              
  Lines       27532    27539       +7     
  Branches     4915     4916       +1     
==========================================
+ Hits        17766    17771       +5     
- Misses       9749     9751       +2     
  Partials       17       17
Impacted Files Coverage Δ
...-viewer/file-too-large/file-too-large.component.ts 25.92% <0%> (ø) ⬆️
src/app/services/ncj/local-template.service.ts 70.49% <0%> (-2.39%) ⬇️
...r/image-file-viewer/image-file-viewer.component.ts 100% <100%> (ø) ⬆️
...rc/@batch-flask/ui/file/file-loader/file-loader.ts 83.33% <100%> (+1.24%) ⬆️
...file-viewer-header/file-viewer-header.component.ts 91.48% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6b876...0d256bb. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 566f299 into master Mar 7, 2019
@timotheeguerin timotheeguerin deleted the feature/edit-btn-local-templates branch March 7, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local template open in default editor should not open a copy Local Template library show full path to file
1 participant