Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Sort subscriptions in subscription picker #1965

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Mar 14, 2019

fix #1963

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #1965 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1965      +/-   ##
==========================================
+ Coverage   64.53%   64.53%   +<.01%     
==========================================
  Files        1012     1012              
  Lines       27674    27676       +2     
  Branches     4923     4924       +1     
==========================================
+ Hits        17859    17861       +2     
  Misses       9799     9799              
  Partials       16       16
Impacted Files Coverage Δ
.../app/services/subscription/subscription.service.ts 71% <100%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069225a...fbf6662. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 273cbb9 into master Mar 14, 2019
@timotheeguerin timotheeguerin deleted the feature/sort-subscription branch March 14, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription list should be sorted
1 participant