Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Job Schedule job release task null error #1979

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

timotheeguerin
Copy link
Member

fix #1978

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #1979 into stable will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           stable   #1979      +/-   ##
=========================================
+ Coverage   64.54%   64.9%   +0.36%     
=========================================
  Files        1012    1013       +1     
  Lines       27693   27699       +6     
  Branches     4930    4934       +4     
=========================================
+ Hits        17874   17978     +104     
+ Misses       9803    9705      -98     
  Partials       16      16
Impacted Files Coverage Δ
...etails/job-schedule-job-specification.component.ts 100% <0%> (ø)
src/app/models/job-release-task.ts 100% <0%> (+10%) ⬆️
...ponents/job/details/job-configuration.component.ts 78.37% <0%> (+59.45%) ⬆️
src/app/decorators/job-decorator.ts 61.53% <0%> (+61.53%) ⬆️
...pp/decorators/task-container-settings-decorator.ts 100% <0%> (+100%) ⬆️
src/app/decorators/job-execution-info-decorator.ts 100% <0%> (+100%) ⬆️
...c/app/decorators/job-preparation-task-decorator.ts 100% <0%> (+100%) ⬆️
src/app/decorators/task-constraints-decorator.ts 100% <0%> (+100%) ⬆️
src/app/decorators/job-release-task-decorator.ts 100% <0%> (+100%) ⬆️
src/app/decorators/job-manager-task-decorator.ts 100% <0%> (+100%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44336c8...0824534. Read the comment docs.

@timotheeguerin timotheeguerin merged commit c73b5e9 into stable Mar 20, 2019
@timotheeguerin timotheeguerin deleted the fix/job-schedule-details-null branch March 20, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant