Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for resetting forms #2691

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Added support for resetting forms #2691

merged 1 commit into from
Mar 23, 2023

Conversation

dpwatrous
Copy link
Member

@dpwatrous dpwatrous commented Mar 23, 2023

Action forms also have a default 'Discard changes' button now

Screenshot 2023-03-23 at 1 27 01 PM

Action forms also have a default 'Discard changes' button now
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2691 (bee9de6) into main (778aca0) will increase coverage by 0.04%.
The diff coverage is 78.18%.

❗ Current head bee9de6 differs from pull request most recent head 68b3315. Consider uploading reports for the commit 68b3315 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2691      +/-   ##
==========================================
+ Coverage   66.14%   66.18%   +0.04%     
==========================================
  Files        1200     1200              
  Lines       33338    33367      +29     
  Branches     6133     6135       +2     
==========================================
+ Hits        22050    22084      +34     
+ Misses      11155    11153       -2     
+ Partials      133      130       -3     
Impacted Files Coverage Δ
packages/common/src/ui-common/form/form.ts 80.00% <ø> (ø)
packages/common/src/ui-common/form/subform.ts 44.44% <0.00%> (-0.92%) ⬇️
...n/src/ui-common/localization/standard-localizer.ts 50.00% <0.00%> (-12.50%) ⬇️
.../src/ui-react/components/form/list-form-layout.tsx 73.97% <ø> (ø)
packages/common/src/ui-common/action/action.ts 81.53% <77.77%> (+6.02%) ⬆️
...es/common/src/ui-common/form/internal/form-impl.ts 80.75% <100.00%> (+0.46%) ⬆️
...eact/src/ui-react/account/create-account-action.ts 92.59% <100.00%> (ø)
...react/src/ui-react/components/form/action-form.tsx 75.00% <100.00%> (+16.66%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778aca0...68b3315. Read the comment docs.

@dpwatrous dpwatrous enabled auto-merge (squash) March 23, 2023 19:29
@dpwatrous dpwatrous merged commit 1154a4e into main Mar 23, 2023
@dpwatrous dpwatrous deleted the dpwatrous/form-reset branch March 23, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants