This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Implement more connection string validators #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifguoMSFT
commented
Jul 16, 2021
| @@ -445,51 +445,11 @@ private async Task<TestConnectionData> TestConnectionAsync(string connectionStri | |||
| { | |||
| if (databaseType == DatabaseType.SqlDatabase || databaseType == DatabaseType.SqlServer) | |||
| { | |||
| using (SqlConnection conn = new SqlConnection()) | |||
There was a problem hiding this comment.
@puneet-gupta @vijaysaayi I re-organized some code in this controller by putting them into public functions so that I can re-use them in ConnectionStringValidatorController
DiagnosticsExtension/Controllers/ConnectionStringValidationController.cs
Outdated
Show resolved
Hide resolved
puneetg1983
reviewed
Jul 19, 2021
DiagnosticsExtension/Controllers/ConnectionStringValidationController.cs
Outdated
Show resolved
Hide resolved
puneetg1983
suggested changes
Jul 19, 2021
DiagnosticsExtension/Controllers/ConnectionStringValidationController.cs
Show resolved
Hide resolved
vijaysaayi
suggested changes
Jul 20, 2021
DiagnosticsExtension/Models/ConnectionStringValidator/KeyVaultValidator.cs
Outdated
Show resolved
Hide resolved
sidkri
reviewed
Jul 20, 2021
DiagnosticsExtension/Controllers/ConnectionStringValidationController.cs
Show resolved
Hide resolved
sidkri
reviewed
Jul 20, 2021
DiagnosticsExtension/Controllers/ConnectionStringValidationController.cs
Outdated
Show resolved
Hide resolved
sidkri
reviewed
Jul 20, 2021
DiagnosticsExtension/Controllers/ConnectionStringValidationController.cs
Outdated
Show resolved
Hide resolved
sidkri
reviewed
Jul 20, 2021
DiagnosticsExtension/Models/ConnectionStringValidator/HttpValidator.cs
Outdated
Show resolved
Hide resolved
DiagnosticsExtension/Models/ConnectionStringValidator/MySqlValidator.cs
Outdated
Show resolved
Hide resolved
puneetg1983
approved these changes
Jul 23, 2021
vijaysaayi
approved these changes
Jul 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySqlValidator,KeyVaultValidator, andHttpValidatorDatabaseTestControllerfor code re-usingConnectionStringValidationControllerand other minor changes