This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Adding more validators to the new connection string validator endpoint #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidkri
commented
Aug 16, 2021
| @@ -364,6 +445,9 @@ | |||
| <ErrorReport>prompt</ErrorReport> | |||
| <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet> | |||
| </PropertyGroup> | |||
| <PropertyGroup> | |||
sidkri
commented
Aug 16, 2021
| </WebProjectProperties> | ||
| </FlavorProperties> | ||
| </VisualStudio> | ||
| </ProjectExtensions> | ||
| <Import Project="..\packages\Microsoft.Azure.Services.AppAuthentication.1.0.3\build\Microsoft.Azure.Services.AppAuthentication.targets" Condition="Exists('..\packages\Microsoft.Azure.Services.AppAuthentication.1.0.3\build\Microsoft.Azure.Services.AppAuthentication.targets')" /> |
sidkri
commented
Aug 16, 2021
| @@ -9,7 +9,7 @@ namespace DiagnosticsExtension.Models.ConnectionStringValidator | |||
| interface IConnectionStringValidator | |||
| { | |||
| // verify provided string is a valid connection string that can be tested by the validator | |||
| bool IsValid(string connStr); | |||
| Task<bool> IsValid(string connStr); | |||
sidkri
commented
Aug 16, 2021
| CloudBlobClient client = storageAccount.CreateCloudBlobClient(); | ||
| client.GetServiceProperties(); | ||
| IEnumerable<CloudBlobContainer> containers = client.ListContainers(); | ||
| if (containers.Count() == 0) |
yifguoMSFT
approved these changes
Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following connections strings are supported with this PR:
Minor refactor of IsValid to be an async function for consistency and incase future validators call async methods (async all the way)