This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
Add nameresolver api #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puneetg1983
suggested changes
Oct 6, 2021
| @@ -0,0 +1,62 @@ | |||
| // ----------------------------------------------------------------------- | |||
| // <copyright file="UdpEchoTestController.cs" company="Microsoft Corporation"> | |||
| { | ||
| /// <summary> | ||
| /// Worker instances are running an udp echo server on port 30000. This controller is for checking the connection between target | ||
| /// worker instance by pinging and checking the echoed result. |
There was a problem hiding this comment.
Please update this to the correct text
There was a problem hiding this comment.
Sorry it's my bad, I was too hurry to push this PR before getting off so that didn't notice this at all. It's now updated.
| } | ||
| else | ||
| { | ||
| result = new NameResolverResult { Status = "unknown error", Exception = e }; |
There was a problem hiding this comment.
I dont know how the caller for this API will look like but do you want to add another field to NameResolverResult (like SocketErrorCode) and just return socketException.SocketErrorCode.ToString() to it ?
puneetg1983
approved these changes
Oct 7, 2021
puneetg1983
added a commit
that referenced
this pull request
Jan 27, 2022
Adding DaaS V2 API Removing additional logging statements Logging improvements Add nameresolver api (#18) * done * resolve PR comments Improving error handling and logging Increment DAAS Version Updating DiagnosticAnalysis.exe to latest Correcting the Attribute routing paths API changes better suited with ARM Handling exception while removing older sessions Correcting response slightly Updating framework to 4.8 and adding controllers for GeoMaster Incrementing version and enabling Diag CLI everywhere Cpu monitoring always on mode (#21) AlwaysOn Monitoring mode ILMerge for DaasRunner and DaasConsole and some CPU monitoring related changes Reducing ServerTimeout slightly Bug fix for SCM separation and CPU monitoring improvements DaaS V 2.1 minor cleaup Minor fixes in DaaS v2 Adding ServerCertificateValidationCallback Propagating error while copying to session Removing sessions from the runningSessions list Handling DaasRunner restarts during V2 sessions Adding DiagCLI report viewer to DaaS Fetch the DiagnosticAnalysis CLI & results viewer from nuget feeds (#23) * Fetch the DiagnosticAnalys CLI from nuget * Fetch the DiagnosticAnalyis HTML report files from nuget
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the nameresolver CLI provides a different result as the user app because it implements its own name resolving logic which can introduce more problems and uncertainty to checks in Network Troubleshooter. For example, nameresolver does not check WEBSITE_DNS_ALT_SERVER. And when both DNS in appsetting are not reachable, nameresolver can still produce a result
Add nameresolver api in DaasExtension to resolve hostname by using C# DNS library, which should provide the same result as the name resolving request sent from user code.