Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluded subnets for Deny Subnets without NSG #456

Closed
krowlandson opened this issue Mar 10, 2021 · 1 comment · Fixed by #630
Closed

Excluded subnets for Deny Subnets without NSG #456

krowlandson opened this issue Mar 10, 2021 · 1 comment · Fixed by #630
Assignees
@jtracey93
Labels
bug Something isn't working

Comments

@krowlandson
Copy link
Contributor

Describe the bug
As per Issue 38 in the Terraform module, the "Deny Subnets without NSG" policy currently doesn't allow for networks needing subnets for internal services which do not support NSGs, such as GatewaySubnet, AzureFirewallSubnet, and AzureFirewallManagementSubnet.

Steps to reproduce

  1. Create a virtual network
  2. Assign the policy
  3. Try to create one of the subnets which do not support NSGs
@krowlandson krowlandson added bug Something isn't working triage labels Mar 10, 2021
@ljtill ljtill removed the triage label Apr 22, 2021
@daltondhcp
Copy link
Contributor

daltondhcp commented Jun 7, 2021 •
edited
Loading

@jtracey93 - would you mind taking a look at this one as well since it is very similar to #604?

This was referenced Jun 16, 2021
Closed
Closed
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jtracey93 jtracey93

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Deny-Subnet-Without-Nsg Policy to Allow Subnet Exclusions
4 participants
@ljtill @krowlandson @daltondhcp @jtracey93