Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer): Deep copy for connections data #2306

Merged
merged 3 commits into from
May 10, 2023
Merged

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented May 10, 2023

Main Code Changes

Closes #2289

By not deep copying the was updated in the safeSetObjectPropertyValue function and was causing not sending the parameterized connection string

MicrosoftTeams-image (14) MicrosoftTeams-image (15)

@ccastrotrejo ccastrotrejo marked this pull request as ready for review May 10, 2023 17:07
Copy link
Contributor

@preetriti1 preetriti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

@ccastrotrejo ccastrotrejo merged commit 9feb127 into main May 10, 2023
@ccastrotrejo ccastrotrejo deleted the ccastro/connections branch May 10, 2023 19:00
@ccastrotrejo ccastrotrejo linked an issue May 10, 2023 that may be closed by this pull request
@ccastrotrejo ccastrotrejo mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code Azure Blob VS Code_Azure Blob as a trigger : Debug failing.
2 participants