feat(designer): [CredentialMapping] Updating the schema #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type field is the enum string name of the credential connection type. In order to query CDS without having to manually map the enum to its ordinal, we are adding the value here.
adboillo
changed the title
rllyy97
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of creating a creating a connection with a credential (instead of username+password), the connector will return the list of credential types that are supported.
Today, this field is the enum string name of the credential connection type.
In order to query CDS without having to manually map the enum to its ordinal, we are adding the value in the AAPT-Connector contract.
Updating here, so that the info is passed to the UX
Design note here
AAPT-Connector PR here: [uiflow] Adding the type enum value to credential mapping
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Please Include Screenshots or Videos of the intended change: