Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Templates): Styling for Templates Parameters #4978

Merged
merged 10 commits into from
Jun 14, 2024

Conversation

Elaina-Lee
Copy link
Contributor

@Elaina-Lee Elaina-Lee commented Jun 13, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Seperates TemplatesParametersField from WorkflowParametersField

  • Adds css styling to the TemplatesParametersField according to the figma design

  • Hides parameter tab on no parameters

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Please Include Screenshots or Videos of the intended change:
    Example 1:
    image
    Example 2:
    image

@Elaina-Lee Elaina-Lee marked this pull request as ready for review June 13, 2024 22:22
@Elaina-Lee Elaina-Lee enabled auto-merge (squash) June 14, 2024 17:47
@Elaina-Lee Elaina-Lee merged commit 8cf13cd into main Jun 14, 2024
11 of 12 checks passed
@hartra344 hartra344 deleted the elaina/styleParameters branch June 17, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants