Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(designer-ui): Allow makers to use class attributes and table styling in raw HTML #5000

Merged
merged 2 commits into from
Jun 20, 2024
Merged

feat(designer-ui): Allow makers to use class attributes and table styling in raw HTML #5000

merged 2 commits into from
Jun 20, 2024

Conversation

ek68794998
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

Users are unable to use class-attribute-based styling in HTML editor, despite this being a valid use case. This was excluded at dev time in favor of style, but as class is still widely used, this change permits use of it.

  • What is the new behavior (if this is a feature change)?

This PR allows use of CSS class attributes, as well as various <table> attributes that users often rely on for formatting emails.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Please Include Screenshots or Videos of the intended change:

image

image

image

@ek68794998 ek68794998 marked this pull request as ready for review June 19, 2024 23:57
@ek68794998 ek68794998 merged commit 3446119 into Azure:main Jun 20, 2024
12 checks passed
@ek68794998 ek68794998 deleted the ek/html-classes branch June 20, 2024 00:26
Eric-B-Wu pushed a commit that referenced this pull request Jun 29, 2024
@ek68794998 @Eric-B-Wu
feat(designer-ui): Allow makers to use class attributes and table…
bc4b7ad 
… styling in raw HTML (#5000)

* Allow `class` attributes and `table` styling

* Update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-B-Wu Eric-B-Wu Eric-B-Wu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ek68794998 @Eric-B-Wu