Add datasets folder to wheel #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add_datasets_to_wheel
jbolor21
approved these changes
Feb 22, 2024
rlundeen2
approved these changes
Feb 22, 2024
dlmgary
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the datasets folder to the wheel because it otherwise causes issues when users don't provide a dataset and use the default (as it's not part of the wheel but expected to be present).
Note that it isn't inside the pyrit package directory, so the installation puts it into a directory at the same level as pyrit like another python package which is not great and could cause confusion and conflicts. We should absolutely address this in a future release, but it'll unblock the next one.
Tests
Documentation