Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: New prompt target: AzureBlobStorageTarget #95

Merged
merged 35 commits into from
Mar 20, 2024
Merged

FEAT: New prompt target: AzureBlobStorageTarget #95

merged 35 commits into from
Mar 20, 2024

Conversation

nina-msft
Copy link
Contributor

@nina-msft nina-msft commented Mar 12, 2024 •
edited
Loading

Description

Adding a new Prompt Target to upload prompts as text files (with both synch and async methods) to a given Azure Blob Storage Container.

Other:

  • This PR also adds the Microsoft copyright notice to all doc/code files, as mentioned in PR feedback

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@nina-msft nina-msft changed the title Users/nichikan/2083 storage account target New prompt target: AzureBlobStorageTarget Mar 12, 2024
@nina-msft nina-msft changed the title New prompt target: AzureBlobStorageTarget [Draft] New prompt target: AzureBlobStorageTarget Mar 12, 2024
dlmgary
dlmgary reviewed Mar 14, 2024
View reviewed changes
doc/code/prompt_targets.py Outdated Show resolved Hide resolved
@nina-msft nina-msft marked this pull request as ready for review March 18, 2024 22:54
@nina-msft nina-msft changed the title [Draft] New prompt target: AzureBlobStorageTarget New prompt target: AzureBlobStorageTarget Mar 18, 2024
@nina-msft nina-msft changed the title New prompt target: AzureBlobStorageTarget FEAT: New prompt target: AzureBlobStorageTarget Mar 18, 2024
dlmgary
dlmgary approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@dlmgary dlmgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few minor comments for updates.

romanlutz
romanlutz reviewed Mar 19, 2024
View reviewed changes
doc/code/prompt_targets.ipynb Outdated Show resolved Hide resolved
doc/code/prompt_targets.py Outdated Show resolved Hide resolved
pyrit/prompt_target/azure_blob_storage_target.py Outdated Show resolved Hide resolved
pyrit/prompt_target/azure_blob_storage_target.py Show resolved Hide resolved
@nina-msft nina-msft merged commit c92e7e6 into Azure:main Mar 20, 2024
4 checks passed
@nina-msft nina-msft deleted the users/nichikan/2083-storage-account-target branch March 20, 2024 00:45
@nina-msft nina-msft mentioned this pull request Mar 25, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz left review comments

@rlundeen2 rlundeen2 rlundeen2 approved these changes

@rdheekonda rdheekonda rdheekonda approved these changes

@dlmgary dlmgary dlmgary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nina-msft @dlmgary @romanlutz @rdheekonda @rlundeen2