Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add log for number of target nginx replicas #144

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

OliverMKing
Copy link
Collaborator

Description

Adds a log printing the number of desired nginx replicas. Useful for informing us if customer manually changes the number of replicas to 0 and records what the HPA is doing.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Nov 28, 2023

Pull Request Test Coverage Report for Build 7025109650

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 80.893%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/nginxingress/nginx_ingress_controller.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller/ingress/concurrency_watchdog.go 1 86.41%
Totals Coverage Status
Change from base Build 7024440125: -0.09%
Covered Lines: 2989
Relevant Lines: 3695

💛 - Coveralls

@OliverMKing OliverMKing merged commit 6f80743 into Azure:main Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants