Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: e2e PR check does not use MSI #45

Merged
merged 1 commit into from
Nov 11, 2022
Merged

ci: e2e PR check does not use MSI #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pipelines/e2e-job-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:
RETAIN_SSH: false
ENABLE_KMS_ENCRYPTION: ${{ parameters.enableKMSEncryption }}
SUBSCRIPTION_ID: '$(SUBSCRIPTION_ID_E2E_KUBERNETES)'
MSI_USER_ASSIGNED_ID: '$(MSI_USER_ASSIGNED_ID_AKS_ENGINE_E2E)'
CONTAINER_RUNTIME: ${{ parameters.containerRuntime }}
BLOCK_SSH: ${{ parameters.runSSHTests }}

Expand Down
1 change: 1 addition & 0 deletions .pipelines/e2e-step-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ steps:
export CLIENT_SECRET=$(SERVICE_PRINCIPAL_CLIENT_SECRET_E2E_KUBERNETES)
export CLIENT_OBJECTID=$(SERVICE_PRINCIPAL_OBJECT_ID_E2E_KUBERNETES)
export AZURE_CORE_ONLY_SHOW_ERRORS=True
export USE_MANAGED_IDENTITY=false
make test-kubernetes
displayName: ginkgo k8s e2e tests
- task: PublishPipelineArtifact@0
Expand Down
1 change: 0 additions & 1 deletion .pipelines/pr-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ jobs:
GOBIN: '$(GOPATH)/bin' # Go binaries path
GOROOT: '/usr/local/go' # Go installation path
GOPATH: '$(Agent.TempDirectory)/go' # Go workspace path
MSI_USER_ASSIGNED_ID_AKS_ENGINE_E2E: ''
REGIONS: ''
SUBSCRIPTION_ID_E2E_KUBERNETES: ''
TENANT_ID: ''
Expand Down
2 changes: 1 addition & 1 deletion examples/e2e-tests/kubernetes/release/default/definition-no-vnet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"orchestratorProfile": {
"kubernetesConfig": {
"useCloudControllerManager": true,
"useManagedIdentity": true,
"useManagedIdentity": false,
"addons": [
{
"name": "coredns",
Expand Down
2 changes: 1 addition & 1 deletion examples/e2e-tests/kubernetes/release/default/definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"orchestratorProfile": {
"kubernetesConfig": {
"useCloudControllerManager": true,
"useManagedIdentity": true,
"useManagedIdentity": false,
"clusterSubnet": "10.239.0.0/16",
"addons": [
{
Expand Down
2 changes: 1 addition & 1 deletion examples/e2e-tests/userassignedidentity/vmas/kubernetes-vmas-multimaster.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"properties": {
"orchestratorProfile": {
"kubernetesConfig": {
"useManagedIdentity": true,
"useManagedIdentity": false,
"userAssignedID": "aksenginetestid"
}
},
Expand Down
2 changes: 1 addition & 1 deletion examples/e2e-tests/userassignedidentity/vmas/kubernetes-vmas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"properties": {
"orchestratorProfile": {
"kubernetesConfig": {
"useManagedIdentity": true,
"useManagedIdentity": false,
"userAssignedID": "aksenginetestid"
}
},
Expand Down
2 changes: 1 addition & 1 deletion examples/e2e-tests/userassignedidentity/vmss/kubernetes-vmss.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"properties": {
"orchestratorProfile": {
"kubernetesConfig": {
"useManagedIdentity": true,
"useManagedIdentity": false,
"userAssignedID": "aksenginetestid"
}
},
Expand Down