-
Notifications
You must be signed in to change notification settings - Fork 522
fix: update Container monitoring add-on with 11012019 agent image changes #2318
Conversation
/assign @jadarsie |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
parts/k8s/containeraddons/1.16/kubernetesmasteraddons-omsagent-daemonset.yaml
Show resolved
Hide resolved
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
@ganga1980 are you able to run the tests locally in the dev container? I believe this will help to avoid the test failures in the CI system. |
|
@ganga1980 I would run |
@devigned, Thanks for pointing this. I was knocking my head why the generated files difference in CI not locally. I have ran "make reload", "make generate" and "make test", and tested my changes by creating cluster with addon. I think, this time would make the CI happy. |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #2318 +/- ##
==========================================
+ Coverage 71.71% 71.73% +0.01%
==========================================
Files 142 142
Lines 24950 24992 +42
==========================================
+ Hits 17892 17927 +35
- Misses 5927 5934 +7
Partials 1131 1131 |
@devigned , seems all the tests and checks are passed. when you get a chance, please help on merging this PR? |
Hi, @devigned , When you get a chance, can you please help on merging this PR? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned, ganga1980, rashmichandrashekar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Issue Fixed:
This PR has changes related updates for the Container monitoring add-on with latest agent image version: 11012019
Requirements:
Notes: