Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes v1.16.14 on Azure Stack #3704

Merged
merged 1 commit into from Aug 17, 2020

Conversation

jadarsie
Copy link
Member

@jadarsie jadarsie commented Aug 14, 2020

Reason for Change:

Pre-pull Azure Stack's custom images for K8s 1.16.14

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #3704 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3704   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files         147      147           
  Lines       25318    25318           
=======================================
  Hits        18525    18525           
  Misses       5655     5655           
  Partials     1138     1138           
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83dff8...a15b55d. Read the comment docs.

@jadarsie jadarsie requested a review from mboersma August 14, 2020 23:29
@jadarsie jadarsie changed the title [wip] feat: add support for K8s v1.16.14 on Azure Stack feat: add support for K8s v1.16.14 on Azure Stack Aug 14, 2020
@jadarsie jadarsie changed the title feat: add support for K8s v1.16.14 on Azure Stack feat: add support for Kubernetes v1.16.14 on Azure Stack Aug 14, 2020
@mboersma
Copy link
Member

mboersma commented Aug 17, 2020

@jadarsie I think you need to rebase off current master to get #3707 and work around the Windows VHD issue. Sorry about that!

Edit: Never mind, I did the rebase.

@mboersma mboersma added the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Aug 17, 2020
@mboersma mboersma removed the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Aug 17, 2020
@mboersma
Copy link
Member

This is failing with QuotaExceeded now, but that pipeline passed before I had to rebase this, so I'm going to merge it.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Aug 17, 2020
@mboersma mboersma merged commit ab019ff into Azure:master Aug 17, 2020
@acs-bot
Copy link

acs-bot commented Aug 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jadarsie, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants