Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: fix network cleanup code on windows for contianerd nodes #4154

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Jan 12, 2021

Reason for Change:

  • Fixes issue when calling cleanupnetwork.ps1 as a stand-alone script
  • Fixes issue when running kubeletstart.ps1 from a directory other than c:\k
  • Fixes issue where 'azure' network is not re-created after network cleanup because logs weren't deleted (logs ended up in c:\windows\system32 due to issue where containerd not setting working directory)

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #4154 (62484dc) into master (bcc8a73) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4154   +/-   ##
=======================================
  Coverage   73.27%   73.27%           
=======================================
  Files         135      135           
  Lines       20720    20720           
=======================================
  Hits        15183    15183           
  Misses       4562     4562           
  Partials      975      975           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc8a73...62484dc. Read the comment docs.

Qdigital
Qdigital previously approved these changes Jan 12, 2021
@jsturtevant
Copy link
Contributor

/lgtm

@acs-bot
Copy link

acs-bot commented Jan 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants