Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support client request id modular and small fixes #1985

Merged
merged 45 commits into from
Aug 29, 2023
Merged

Support client request id modular and small fixes #1985

merged 45 commits into from
Aug 29, 2023

Conversation

MaryGao
Copy link
Member

@MaryGao MaryGao commented Aug 21, 2023 •
edited
Loading

fixes #1957

  • Ignore below headers in modular
    return-client-request-id
    ocp-date
    client-request-id

  • Support Array<Error> and Record<Error>

  • Add status check if no isUnexpected helper in RLC

@MaryGao MaryGao marked this pull request as ready for review August 21, 2023 09:48
qiaozha
qiaozha reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove any consolde.log code if it's debugging. thx

packages/typespec-ts/src/transform/transformApiVersionInfo.ts Outdated Show resolved Hide resolved
packages/typespec-ts/src/utils/operationUtil.ts Outdated Show resolved Hide resolved
packages/typespec-ts/src/utils/operationUtil.ts Outdated Show resolved Hide resolved
packages/typespec-ts/src/utils/operationUtil.ts Outdated Show resolved Hide resolved
packages/typespec-ts/src/utils/operationUtil.ts Outdated Show resolved Hide resolved
packages/typespec-ts/test/modularIntegration/collectionFormat.spec.ts Outdated Show resolved Hide resolved
packages/typespec-ts/test/modularIntegration/customClientRequestId.spec.ts Show resolved Hide resolved
packages/typespec-ts/test/modularIntegration/customClientRequestId.spec.ts Show resolved Hide resolved
packages/typespec-ts/test/modularIntegration/customClientRequestId.spec.ts Show resolved Hide resolved
packages/rlc-common/src/buildObjectTypes.ts Outdated Show resolved Hide resolved
@MaryGao MaryGao changed the title Support client request id modular and append default error response if absent Support client request id modular Aug 28, 2023
@MaryGao MaryGao changed the title Support client request id modular Support client request id modular and small fixes Aug 28, 2023
qiaozha
qiaozha approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/typespec-ts/src/modular/helpers/operationHelpers.ts Outdated Show resolved Hide resolved
MaryGao and others added 2 commits August 29, 2023 13:47
@MaryGao @qiaozha
Update packages/typespec-ts/src/modular/helpers/operationHelpers.ts
16b1342 
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
@MaryGao
update the order
7890b6b
@MaryGao MaryGao merged commit 47adf85 into Azure:main Aug 29, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe left review comments

@qiaozha qiaozha qiaozha approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modular: Handle special header client-Request-Id
3 participants
@MaryGao @lirenhe @qiaozha