Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace c8 with nyc for coverage in generated packages #2446

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

jeremymeng
Copy link
Contributor

@jeremymeng jeremymeng commented Apr 15, 2024

Switching back to nyc as done in the js mono repo: Azure/azure-sdk-for-js@e9561c1

The c8 version azure-sdk-for-js repro has been upgraded to ^9.1.0 already.
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be related, but what is this c8 being used for in our sdk repo ? I can't find anywhere that refers to this package.

@jeremymeng
Copy link
Contributor Author

Might not be related, but what is this c8 being used for in our sdk repo ? I can't find anywhere that refers to this package.

It is used for code coverage (previously we used nyc but that has problem with esm)

https://github.com/Azure/azure-sdk-for-js/blob/83ef149d60001cb53ca412208e265e327598c1b9/common/tools/dev-tool/src/commands/run/testNodeJSInput.ts#L34

@qiaozha
Copy link
Member

qiaozha commented Apr 17, 2024

Might not be related, but what is this c8 being used for in our sdk repo ? I can't find anywhere that refers to this package.

It is used for code coverage (previously we used nyc but that has problem with esm)

https://github.com/Azure/azure-sdk-for-js/blob/83ef149d60001cb53ca412208e265e327598c1b9/common/tools/dev-tool/src/commands/run/testNodeJSInput.ts#L34

Thanks for the pointers, I was searching the sdk folder. 😄

@jeremymeng
Copy link
Contributor Author

Thinking about it more. I actually want to switch back to nyc now that we removed esm dev dependency.

@jeremymeng jeremymeng changed the title Upgrade c8 version to ^9.1.0 in generated packages Replace c8 with nyc for coverage in generated packages Apr 19, 2024
@jeremymeng jeremymeng merged commit 8b555e2 into Azure:main Apr 23, 2024
28 checks passed
@jeremymeng jeremymeng deleted the c8-9.1.0 branch April 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants