This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Fix: spark debug tool filter out .venv, make debug tool testable #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafreck
changed the title
.style.yapf
Outdated
| @@ -3,5 +3,5 @@ based_on_style=pep8 | |||
| spaces_before_comment=4 | |||
| split_before_logical_operator=True | |||
| indent_width=4 | |||
| column_limit=140 | |||
There was a problem hiding this comment.
No I can leave it at 140 if you want. I'm not sure what the best thing is here.
| @@ -10,7 +10,7 @@ | |||
| from subprocess import STDOUT, CalledProcessError, check_output | |||
| from zipfile import ZIP_DEFLATED, ZipFile | |||
|
|
|||
| import docker # pylint: disable=import-error | |||
| import docker # pylint: disable=import-error | |||
There was a problem hiding this comment.
are those space added by the formatter?
aztk_cli/utils.py
Outdated
| if isinstance(result, Exception): | ||
| log.info("%s\n", result) | ||
| def log_node_output(node_output): | ||
| print("NodeOutput", node_output.output) |
There was a problem hiding this comment.
ah this is a debug statement, will remove. thanks!
aztk/spark/utils/debug.py
Outdated
| for tarinfo in members: | ||
| if (os.path.splitext(tarinfo.name)[1] not in skip_extensions and | ||
| os.path.basename(tarinfo.name) not in skip_files): | ||
| if (not any(directory in skip_directories for directory in os.path.normpath(tarinfo.name).split(os.sep)) and |
There was a problem hiding this comment.
can you split this condition to make it look nicer
timotheeguerin
approved these changes
Jun 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #609