Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test coverage for "containerapp service redis/postgres delete" #6327

Merged
merged 1 commit into from
May 26, 2023

Conversation

yash-nisar
Copy link
Contributor

Closes #6302


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @yash-nisar,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@ghost ghost requested a review from yonzhan May 25, 2023 21:37
@ghost ghost added the Auto-Assign Auto assign by bot label May 25, 2023
@ghost ghost requested a review from wangzelin007 May 25, 2023 21:37
@yonzhan
Copy link
Collaborator

yonzhan commented May 25, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yanzhudd May 25, 2023 21:37
@ghost ghost assigned zhoxing-ms May 25, 2023
@ghost ghost added the ContainerApp label May 25, 2023
@ghost ghost requested review from zhoxing-ms and jsntcy May 25, 2023 21:37
@zhoxing-ms zhoxing-ms merged commit ec36c77 into Azure:main May 26, 2023
@yash-nisar yash-nisar deleted the update-test branch June 15, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test cover for "az containerapp service XX delete" commands
4 participants