-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor azure service mesh update function for better readability #7201
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks mesh disable | cmd aks mesh disable removed property confirmation |
Hi @deveshdama, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Feature owner queued live test, test passed!
* Link HCRP machine to vCenter * Update VM create examples * small nit * lint fixes * lint fixes * error msg improv * lint fix * release 0.2.4 * Update src/connectedvmware/azext_connectedvmware/_help.py Co-authored-by: ZelinWang <zelinwang@microsoft.com> * Update src/connectedvmware/azext_connectedvmware/_help.py Co-authored-by: ZelinWang <zelinwang@microsoft.com> --------- Co-authored-by: ZelinWang <zelinwang@microsoft.com>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=124507&view=results Last commit: dab6605
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=124522&view=results Last commit: be4df69
* add operation result
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=124822&view=results Last commit: d95044c
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=124836&view=results Last commit: e91f1a6
* portal default - create update delete
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=125250&view=results Last commit: 8979fc3
…ly` to support managing assembly (#7175) * integration * Update HISTORY.rst
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=125268&view=results Last commit: 4e1c943
…u` (#7219) * add list sku and list vcores
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=125680&view=results Last commit: 7d8368b
…te-endpoint-connection list`, and `sync-group cloud-endpoint trigger-change-detection` (#7220) * add `storagesync check-name-availability` `storagesync private-endpoint-connection list` `storagesync registered-server trigger-rollover` `storagesync sync-group cloud-endpoint trigger-change-detection` * add test, need to manually register agent, some features have been deprecated, remove trigger rollover for certificate as it requires custom code from service side * style * update version
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=125712&view=results Last commit: f6cc423
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/internal/_build/results?buildId=125945&view=results Last commit: b5a0a3f
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
all
az aks mesh
commands.General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.