Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Add new command: az aks nodepool delete-machines #7248

Merged
merged 17 commits into from
Feb 8, 2024

Conversation

xuexu6666
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks nodepool delete-machines
delete machines API was added to 2023-10-02-preview

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 2, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd aks nodepool delete-machines cmd aks nodepool delete-machines added

Copy link

Hi @xuexu6666,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @xuexu6666,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 2, 2024

AKS

src/aks-preview/HISTORY.rst Show resolved Hide resolved
src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved
@yanzhudd
Copy link
Contributor

yanzhudd commented Feb 7, 2024

please resolve code conflicts

@xuexu6666
Copy link
Contributor Author

@zhoxing-ms

Resolved your comments. Mind a final look? Thanks.

@yanzhudd yanzhudd merged commit e71b504 into Azure:main Feb 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants