Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confcom] updating diff mode and adding cs2 #7500

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

SethHollandsworth
Copy link
Contributor

@SethHollandsworth SethHollandsworth commented Apr 12, 2024

Diff mode was not previously robust enough to handle multiple of the same image with different commands, env vars, etc. This change allows for that to be possible and clearer by using the container name as a key instead of the image name.

Adding configmap sidecar for additional feature in ACI

Fixing bug for seccompProfile field inside of securityContext

Also fixing a bug where you could not use regex for arm templates by leaving out a default value in the parameters.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az confcom

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 12, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 12, 2024

confcom

Copy link

⚠️ Release Suggestions

Module: confcom

  • Update version to 1.0.0 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@@ -2,6 +2,12 @@

Release History
===============
0.3.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update version as bot recommended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we are waiting for a particular feature to be ready and merged to make a 1.0.0 version. Thanks!

@SethHollandsworth
Copy link
Contributor Author

update: the feature we are waiting on should be done and published by the end of this month. So 0.3.5 will probably be the last version before 1.0.0

@SethHollandsworth SethHollandsworth changed the title [confcom] updating diff mode and regex bug fix [confcom] updating diff mode and adding cs2 Apr 18, 2024
@kairu-ms kairu-ms merged commit ea2fb8e into Azure:main Apr 19, 2024
15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/azclitools/release/_build/results?buildId=150273&view=results

blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
* making diff mode more robust

* fixing bug when trying to do regex via parameters

* changing how seccompProfile is interacted with in the template

* adding configmaps as a possible source of information from ARM template

* adding cs2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants