add --ampls-resource-id and --enable-high-log-scale-mode options #7754

ganga1980 · 2024-06-28T05:34:25Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-06-28T05:34:28Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️aks-preview

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd aks addon enable cmd aks addon enable added parameter ampls_resource_id

⚠️ 1006 - ParaAdd aks addon enable cmd aks addon enable added parameter enable_high_log_scale_mode

⚠️ 1006 - ParaAdd aks addon update cmd aks addon update added parameter ampls_resource_id

⚠️ 1006 - ParaAdd aks addon update cmd aks addon update added parameter enable_high_log_scale_mode

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter ampls_resource_id

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_high_log_scale_mode

⚠️ 1006 - ParaAdd aks enable-addons cmd aks enable-addons added parameter ampls_resource_id

⚠️ 1006 - ParaAdd aks enable-addons cmd aks enable-addons added parameter enable_high_log_scale_mode

yonzhan · 2024-06-28T05:34:38Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2024-06-28T05:37:54Z

For more info about extension versioning, please refer to Extension version schema

FumingZhang

please add some live tests for the newly added options.

src/aks-preview/azext_aks_preview/custom.py

… main

yanzhudd · 2024-07-01T02:45:35Z

please fix the CI issues

ganga1980 · 2024-07-01T03:35:27Z

Hi, @yanzhudd , @FumingZhang - CI test failures not to related to this PR and CI test failures related to this test "FAILED src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_create_with_pod_ip_allocation_mode_static_block" and I see same CI tests failures in other PRs also.

FumingZhang · 2024-07-01T04:57:11Z

/azp run

azure-pipelines · 2024-07-01T04:57:22Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang

lgtm

Queued live test to validate the change.

test_aks_create_with_monitoring_aad_auth_with_highlogscale
test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls
test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls_with_highlogscale

failed with error

azure.cli.testsdk.exceptions.JMESPathCheckAssertionError: Query 'properties.dataCollectionEndpointId' doesn't yield expected value '/subscriptions/79a7390d-3a85-432d-9f6f-a11a703c8b83/resourceGroups/clitestfk7a24nt2b/providers/Microsoft.Insights/dataCollectionEndpoints/MSCI-ingest-westus2-cliakstestgm5hrh', instead the actual value is '/subscriptions/79a7390d-3a85-432d-9f6f-a11a703c8b83/resourceGroups/clitestfk7a24nt2b/providers/Microsoft.Insights/dataCollectionEndpoints/MSCI-westus2-cliakstestgm5hrh'. Data: ...

azure.cli.core.azclierror.HTTPError: Not Found({"error":{"code":"ResourceNotFound"}})

FumingZhang · 2024-07-01T06:23:28Z

lgtm

Queued live test to validate the change.

test_aks_create_with_monitoring_aad_auth_with_highlogscale

test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls

test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls_with_highlogscale

failed with error

azure.cli.testsdk.exceptions.JMESPathCheckAssertionError: Query 'properties.dataCollectionEndpointId' doesn't yield expected value '/subscriptions/79a7390d-3a85-432d-9f6f-a11a703c8b83/resourceGroups/clitestfk7a24nt2b/providers/Microsoft.Insights/dataCollectionEndpoints/MSCI-ingest-westus2-cliakstestgm5hrh', instead the actual value is '/subscriptions/79a7390d-3a85-432d-9f6f-a11a703c8b83/resourceGroups/clitestfk7a24nt2b/providers/Microsoft.Insights/dataCollectionEndpoints/MSCI-westus2-cliakstestgm5hrh'. Data: ...

azure.cli.core.azclierror.HTTPError: Not Found({"error":{"code":"ResourceNotFound"}})

Requeued test

FumingZhang · 2024-07-16T02:54:43Z

Requeued another live test

FumingZhang · 2024-07-22T05:49:13Z

Queued live test

test_aks_create_with_monitoring_aad_auth_with_highlogscale
test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls
test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls_with_highlogscale

src/aks-preview/HISTORY.rst

FumingZhang · 2024-07-29T05:36:54Z

/azp run

azure-pipelines · 2024-07-29T05:37:06Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2024-07-30T06:45:58Z

Live test failed

FumingZhang · 2024-07-31T06:50:58Z

Please fix style issues.
https://dev.azure.com/azclitools/public/_build/results?buildId=177380&view=logs&j=506b8f13-8269-5210-246e-a3964e53141e&t=db7247cb-300d-5b59-fd6c-6258fad20b89&l=152

ERROR: ************* Module azext_aks_preview._helpers
src/aks-preview/azext_aks_preview/_helpers.py:346:11: W0718: Catching too general exception Exception (broad-exception-caught)
src/aks-preview/azext_aks_preview/_helpers.py:338:19: W1508: os.getenv default type is builtins.bool. Expected str or None. (invalid-envvar-default)

Requeued live test, test passed!

FumingZhang

lgtm

Please update VERSION (in file src/aks-preview/setup.py) to 7.0.0b3

FumingZhang · 2024-07-31T07:14:19Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

+            )
+        finally:
+            if monitor_options_specified and (
+                core_version < "2.63.0" and


not blocking: it would be better to do the comparison semantically

azclibot · 2024-08-01T04:51:58Z

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=177816&view=results

add --ampls-resource-id and --enable-high-log-scale-mode options

ae7e6bb

ganga1980 requested review from andyliuliming and FumingZhang as code owners June 28, 2024 05:34

azure-client-tools-bot-prd bot added this to the June 2024 (2024-07-09) milestone Jun 28, 2024

FumingZhang reviewed Jun 28, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved

yonzhan requested review from zhoxing-ms and yanzhudd June 28, 2024 07:10

yonzhan assigned zhoxing-ms Jun 28, 2024

fix pr feedback

1aed0eb

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 28, 2024

ganga1980 added 5 commits June 28, 2024 12:58

fix pr feedback

064d7e0

resolve merge conflicts

85bbb7c

Merge branch 'Azure:main' into main

c560c45

resolve merge conflicts

103ee15

Merge branch 'main' of github.com:ganga1980/azure-cli-extensions into…

6121ff8

… main

github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 28, 2024

ganga1980 added 5 commits June 28, 2024 14:26

add live tests

3f7c7dd

fix pr feedback

13ee00f

fix pr feedback

65c4e64

fix pr feedback

2124e2a

lint errors

5f3d03b

FumingZhang reviewed Jul 1, 2024

View reviewed changes

fix merge conflicts

3dcda47

ganga1980 added 4 commits July 16, 2024 22:33

comment tests since require latest az cli

3c7de7e

fix merge conflicts

2534b11

Merge branch 'Azure:main' into main

a760193

re-enable tests

728aa2e

FumingZhang reviewed Jul 22, 2024

View reviewed changes

src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved

ganga1980 added 4 commits July 21, 2024 23:21

fix pr feedback

8077f6a

fix merge conflicts

ca413b9

fix lint errors

c5b5ef6

Merge branch 'Azure:main' into main

957b9ef

Merge branch 'Azure:main' into main

56ba2ce

ganga1980 added 4 commits July 30, 2024 21:58

Merge branch 'Azure:main' into main

0f37111

fix bug

8f9fb5c

fix lint errors

bebdae5

fix lint errors

ad84ede

fix lint errors

007f7af

FumingZhang reviewed Jul 31, 2024

View reviewed changes

bump aks-preview version

9a6d01c

FumingZhang approved these changes Jul 31, 2024

View reviewed changes

yanzhudd approved these changes Jul 31, 2024

View reviewed changes

yanzhudd merged commit a297133 into Azure:main Jul 31, 2024
19 checks passed

FumingZhang mentioned this pull request Sep 11, 2024

--ampls-resource-id is not available in aks-preview Azure/azure-cli#29296

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add --ampls-resource-id and --enable-high-log-scale-mode options #7754

add --ampls-resource-id and --enable-high-log-scale-mode options #7754

ganga1980 commented Jun 28, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Jun 28, 2024 •

edited

Loading

yonzhan commented Jun 28, 2024

github-actions bot commented Jun 28, 2024 •

edited

Loading

FumingZhang left a comment

yanzhudd commented Jul 1, 2024

ganga1980 commented Jul 1, 2024

FumingZhang commented Jul 1, 2024

azure-pipelines bot commented Jul 1, 2024

FumingZhang left a comment •

edited

Loading

FumingZhang commented Jul 1, 2024

FumingZhang commented Jul 16, 2024

FumingZhang commented Jul 22, 2024 •

edited

Loading

FumingZhang commented Jul 29, 2024

azure-pipelines bot commented Jul 29, 2024

FumingZhang commented Jul 30, 2024

FumingZhang commented Jul 31, 2024 •

edited

Loading

FumingZhang left a comment •

edited

Loading

FumingZhang Jul 31, 2024

azclibot commented Aug 1, 2024

add --ampls-resource-id and --enable-high-log-scale-mode options #7754

add --ampls-resource-id and --enable-high-log-scale-mode options #7754

Conversation

ganga1980 commented Jun 28, 2024 • edited Loading

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Jun 28, 2024 • edited Loading

yonzhan commented Jun 28, 2024

github-actions bot commented Jun 28, 2024 • edited Loading

FumingZhang left a comment

Choose a reason for hiding this comment

yanzhudd commented Jul 1, 2024

ganga1980 commented Jul 1, 2024

FumingZhang commented Jul 1, 2024

azure-pipelines bot commented Jul 1, 2024

FumingZhang left a comment • edited Loading

Choose a reason for hiding this comment

FumingZhang commented Jul 1, 2024

FumingZhang commented Jul 16, 2024

FumingZhang commented Jul 22, 2024 • edited Loading

FumingZhang commented Jul 29, 2024

azure-pipelines bot commented Jul 29, 2024

FumingZhang commented Jul 30, 2024

FumingZhang commented Jul 31, 2024 • edited Loading

FumingZhang left a comment • edited Loading

Choose a reason for hiding this comment

FumingZhang Jul 31, 2024

Choose a reason for hiding this comment

azclibot commented Aug 1, 2024

ganga1980 commented Jun 28, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Jun 28, 2024 •

edited

Loading

github-actions bot commented Jun 28, 2024 •

edited

Loading

FumingZhang left a comment •

edited

Loading

FumingZhang commented Jul 22, 2024 •

edited

Loading

FumingZhang commented Jul 31, 2024 •

edited

Loading

FumingZhang left a comment •

edited

Loading