Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} upgrade wheel to 0.34.2 #12583

Closed
wants to merge 1 commit into from
Closed

Conversation

kapilt
Copy link

@kapilt kapilt commented Mar 13, 2020

addresses #12582

History Notes:

[azure-cli-core]: upgrade wheel package

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 13, 2020

add to S167

@yungezz
Copy link
Member

yungezz commented Mar 13, 2020

this is related to issue #12582

@haroldrandom haroldrandom changed the title azure-cli-core - upgrade wheel deep {Packaging} upgrade wheel to 0.34.2 Mar 14, 2020
@haroldrandom
Copy link
Contributor

Hi, @kapilt, appreciated the contribution!

Could you give us some context about the upgrade of wheel?
We found the wheel version is not consistent inside several Azure CLI repos, also want to make it consistency.

@kapilt
Copy link
Author

kapilt commented Mar 14, 2020

its causing spurious upgrades/downgrades for projects with azure-cli-core as a dependency.

the underlying wheel api here is public and stable so its unclear why its pinned at all.

probably the bigger issue, its also unclear why its being listed as an install dep since its not used by the library just the wheel packaging.

@haroldrandom
Copy link
Contributor

haroldrandom commented Mar 16, 2020

We should all the wheel version for all packages inside Azure/azure-cli.
Also, we shall align the wheel version of Azure/azure-cli-extensions and Azure/azure-cli-dev-tools with this.

@fengzhou-msft
Copy link
Member

Original PR to pin wheel to 0.30.0: #8896. As long as the issue no longer exists, we should upgrade wheel probably with 'wheel~=0.34.2' or even unpin it.

@haroldrandom
Copy link
Contributor

haroldrandom commented Mar 16, 2020

Add context:

  1. Extensions built with the latest version of 'wheel' will not show metadata Extensions built with the latest version of 'wheel' will not show metadata. azure-cli-extensions#128
  2. Remove metadata.json from the generated files in .dist-info pypa/wheel#195

If this upgrad, need to take care of this hotfix.

@haroldrandom
Copy link
Contributor

haroldrandom commented Mar 18, 2020

Sorry, upgrade of wheel needs to involve modifying our infrasturre on how to identify Python package. It needs a bit effort to refactor.
But we will plan to relex the restriction ASAP. Sorry for the inconvenience.

@haroldrandom
Copy link
Contributor

Relaxed the limit in #12782.

@haroldrandom
Copy link
Contributor

haroldrandom commented Apr 28, 2020

Sorry, plan changed, since relax this need more tests, reverted in #13198
Unpining wheel would be available in the next releases. Won't be late before Azure CLI 3.0

@azure-sdk azure-sdk added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants