Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixIllegalStateException #395

Closed
wants to merge 1 commit into from
Closed

fixIllegalStateException #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/java/com/microsoft/azure/cosmosdb/internal/directconnectivity/RntbdTransportClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ private Options() {
this.bufferPageSize = 8192;
this.connectionTimeout = null;
this.idleChannelTimeout = Duration.ZERO;
this.idleEndpointTimeout = Duration.ofSeconds(70L);
simplynaveen20 marked this conversation as resolved.
Show resolved Hide resolved
this.idleEndpointTimeout = Duration.ofHours(1);
this.maxBufferCapacity = 8192 << 10;
this.maxChannelsPerEndpoint = 10;
this.maxRequestsPerChannel = 30;
Expand Down
13 changes: 8 additions & 5 deletions ...om/microsoft/azure/cosmosdb/internal/directconnectivity/rntbd/RntbdClientChannelPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,12 +605,15 @@ public void operationComplete(Future<Channel> future) {
}

private void fail(Throwable cause) {
if (this.acquired) {
this.pool.decrementAndRunTaskQueue();
} else {
this.pool.runTaskQueue();
}
this.originalPromise.setFailure(cause);

if (!this.pool.isClosed()) {
simplynaveen20 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

@simplynaveen20 simplynaveen20 Dec 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add test case by lowering the value of IEP, and wait before making first request

if (this.acquired) {
this.pool.decrementAndRunTaskQueue();
} else {
this.pool.runTaskQueue();
}
}
}
}

Expand Down