Fix date format for non-english locale #52
Conversation
|
@fpaparoni thanks for the PR. I wonder if we can have a unit test for this which Utils.nowAsRFC1123() returns the correct value for Non US Locale? Can you please add that too? |
|
Utils.nowAsRFC1123() now always returns a value for Locale.US because otherwise it isn't accepted by cosmosdb, so I don't understand a test for non US Locale. |
|
I assume on non-english locale in the absence of your PR Utils.nowAsRFC1123() returns invalid type format. am I right? if so then maybe we can have a unit test which sets the non-english locale in the JVM, gets the value of validate Utils.nowAsRFC1123() time and format, and then set back default locale in the JVM. This test will pass for your PR, but will fail in the absence of your PR. |
|
|
|
Ok I understood the purpose of it and I pushed the unit test |
| DateTimeFormatter.ofPattern("EEE, dd MMM yyyy HH:mm:ss zzz",Locale.US); | ||
| String time=Utils.nowAsRFC1123(); | ||
| Locale.setDefault(Locale.US); | ||
| RFC_1123_DATE_TIME.parse(time); |
There was a problem hiding this comment.
does RFC_1123_DATE_TIME.parse(time) fail without your bugfix?
There was a problem hiding this comment.
Yes because Utils.nowAsRFC1123 without bugfix returns time depending on Locale of your enviroment. Setting it to a Locale different from US and expecting to parse this String will throw an Exception of date format
|
Thank you @fpaparoni merging this PR. |
No description provided.