Move "current-user" settings out of config.json
#2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the identity of currently logged in user (either the home account id, when logged in as a user, or the client and tenant id when logged in as a service principal) as stored in user's `config.json`. A downside of storing this information in `config.json` is that when a user did `azd config reset`, it would "log out" the current user, which is very surprising behavior. In addition, anyone looking at `config.json` would see properties that were much more like state of the auth subsystem instead of actual config values that a user would want to change. So, this change moves this information out of `config.json` and instead stores it in `auth.json` (a new file) which is also stored in `~/.azd`. On first use, we'll migrate the relevent properties from `config.json` into `auth.json`. Fixes Azure#1721
ellismg
requested review from
wbreza,
vhvb1989,
hemarina and
weikanglim
as code owners
ghost
assigned 
weikanglim
reviewed
May 2, 2023
weikanglim
reviewed
May 2, 2023
weikanglim
reviewed
May 2, 2023
weikanglim
reviewed
May 2, 2023
weikanglim
reviewed
May 2, 2023
weikanglim
approved these changes
May 2, 2023
vhvb1989
approved these changes
May 2, 2023
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSIContainerDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference (preview)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the identity of currently logged in user (either the home account id, when logged in as a user, or the client and tenant id when logged in as a service principal) as stored in user's
config.json.A downside of storing this information in
config.jsonis that when a user didazd config reset, it would "log out" the current user, which is very surprising behavior. In addition, anyone looking atconfig.jsonwould see properties that were much more like state of the auth subsystem instead of actual config values that a user would want to change.So, this change moves this information out of
config.jsonand instead stores it inauth.json(a new file) which is also stored in~/.azd.On first use, we'll migrate the relevent properties from
config.jsonintoauth.json.Fixes #1721