-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deployment status tracking for linux web apps #3763
Conversation
/azp run azure-dev - template - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a one-pass.. Overall looks good. I think the code is all in the right places, just some comments on such smaller implementation details.
I'm also looking into what we might want to do to surface the progress messages for better UX, it's likely important we have some progress indicator as the deployment is waiting for the site to start up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a one-pass.. I think the code looks good overall, just left some comments on such smaller implementation details.
I'm also looking into what we might want to do to surface the progress messages for better UX, it's likely important we have some progress indicator as the deployment is waiting for the site to start up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks really good and moves us in the right direction. It's great to get more detailed errors out of the system and some details about what is happening with this PR and I'm excited for the follow-up later that lets us start reporting more status around what's happening during the full deployment when we go and move away from PollUntilDone
in favor of something that lets us grab the detailed status message and report it on each poll.
I'm happy here once Wei is happy, I a +1 to his feedback.
Great work here, @hemarina - I love how these changes make the tool feel more alive and friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hemarina, Thanks for doing this! This will help users a lot with better error messages for diagnosing upload failures
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIDocumentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
fix #3260