-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quotes added around activity function string parameter in isolated mode #2674
Comments
#2677 same problem |
Facing same problem. Downgrade to 1.0.4 helped. |
Linking this here microsoft/durabletask-dotnet#245 |
@Ilia-Kosenkov that is the cause indeed. The dotnet worker special cases |
I have the same problem. However, if I downgrade
|
Is there an ETA for the fix to be released? Not wanting to be rude, but the current release is basically broken for 2 months now. We'd really like to upgrade to resolve other issues. |
@jviau would it be possible to get a new release of |
@nilsmehlhorn Fix is already released in Microsoft.Azure.Functions.Worker.Extensions.DurableTask 1.1.1 |
@nilsmehlhorn @jviau We are experiencing the issue with quotes added to string parameters in activity functions in Java. Our existing orchestration broke out of the blue and digging around I found this issue. In our case, it seems to be happening only when testing locally on windows (the orchestration works on a linux app service plan in azure). Issue reported in durabletask-java/issues/193 |
Hi, the problem still exists in Microsoft.Azure.Functions.Worker.Extensions.DurableTask 1.1.1. public async Task Run( Blob's path become "input-"abc"" |
Description
Using Microsoft.Azure.Functions.Worker.Extensions.DurableTask version 1.1.0, when you pass a string parameter to an activity function (as a parameter with the [ActivityTrigger] attribute), the activity function receives it with quotes added around it.
I have an app that uses Durable Functions isolated mode in .NET 7, and when I upgraded the Microsoft.Azure.Functions.Worker.Extensions.DurableTask package to 1.1.0 this started happening. Thinking it might be something to do with my code, I used the new project wizard in Visual Studio to create a new Durable Functions isolated project and chose to have it create an orchestration function, so I now had the example "SayHello" app. Running this, it generates the expected
Saying hello to Tokyo
,Saying hello to Seattle
,Saying hello to London
messages. But when I updated the NuGet packages so that I'm now using Microsoft.Azure.Functions.Worker.Extensions.DurableTask 1.1.0, it now generatesSaying hello to "Tokyo"
,Saying hello to "Seattle"
,Saying hello to "London"
. Also, if you break in the SayHello function, you'll see that the variable "name" doesn't just contain, say, "Tokyo," it contains "\"Tokyo\"".I expected that the activity function would receive the string passed in the CallAcivityAsync call unchanged, as it did in previous versions of the library.
Actual behavior
The activity function received the string with quotes added around it.
Relevant source code snippets
You can get this code by just creating the default app with the wizard in Visual Studio, but here are the relevant parts of the code. The orchestration function calls the activity function here:
And then the activity function starts with:
In that function, "name" contains (for the above call)
"Tokyo"
.Known workarounds
None that I know of, except for stripping the quotes out of any strings passed to activity functions.
App Details
Microsoft.Azure.Functions.Worker.Extensions.DurableTask 1.1.0
Azure Functions runtime version 4
Programming language used: C#
The text was updated successfully, but these errors were encountered: