[pack] adding support for IWebJobsConfigurationStartup #5991
Conversation
brettsam
requested review from
yojagad,
ankitkumarr and
fabiocav
and removed request for
yojagad
|
@brettsam any idea on what the impact to cold start/initialization is with these changes? @safihamid would be good to update the profile to ensure this new code path is optimized. |
|
@safihamid is there an easy way to gather numbers on a build from this PR? I agree that'd be good to look at. Of course the actual real-life numbers may vary as this calls into customer code, but we can make sure that our code isn't doing anything crazy here. |
|
I will get some profiles with this PR next week. |
| sb.AppendLine($" Function '{invalidValueMap.Key}' uses the modified key(s): {string.Join(", ", invalidValueMap.Value)}"); | ||
| } | ||
|
|
||
| _logger.LogWarning(new EventId(700, "ConfigurationModifiedInExternalStartup"), sb.ToString()); |
There was a problem hiding this comment.
As discussed, we need to think about a hard failure here if running in consumption. At the very least, we need detectors to ensure it's easy to diagnose when scaling stops working because of potential misconfiguration.
azure-pipelines.yml
Outdated
| @@ -405,7 +405,7 @@ jobs: | |||
| inputs: | |||
| command: 'test' | |||
| testRunTitle: "C# end to end tests" | |||
| arguments: '--filter "Group=CSharpEndToEndTests"' | |||
| arguments: '--filter "Group=CSharpEndToEndTests" -v n' | |||
…ating binding expressions
src/WebJobs.Script/DependencyInjection/ExternalConfigurationStartupValidator.cs
Show resolved
Hide resolved
src/WebJobs.Script/DependencyInjection/ExternalConfigurationStartupValidatorService.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
When will this be released to V3? |
|
It's all merged in but the release has not been pushed to production yet. I'd expect it to be everywhere in about 2 weeks. |
No description provided.