-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ByteType Support #224
Add ByteType Support #224
Conversation
Signed-off-by: choipureum <pooreumsunny@gmail.com>
Signed-off-by: choipureum <pooreumsunny@gmail.com>
Signed-off-by: poo <poo1994@hanmail.net>
Signed-off-by: poo <poo1994@hanmail.net>
Signed-off-by: poo <poo1994@hanmail.net>
Signed-off-by: poo <poo1994@hanmail.net>
Signed-off-by: poo <poo1994@hanmail.net>
Signed-off-by: poo <poo1994@hanmail.net>
Signed-off-by: poo <poo1994@hanmail.net>
Signed-off-by: poo <poo1994@hanmail.net>
Signed-off-by: poo <poo1994@hanmail.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! We need to take a further look for the byte[]
support.
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Visitors/ByteTypeVisotor.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: poo <poo1994@hanmail.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I've left comments in many places, they are all minor changes. Would you please take a look and apply changes?
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Visitors/ByteArrayTypeVisotor.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Visitors/ByteArrayTypeVisotor.cs
Outdated
Show resolved
Hide resolved
...rosoft.Azure.WebJobs.Extensions.OpenApi.TestApp/Get_ApplicationJson_ByteArray_HttpTrigger.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/Visitors/ByteArrayTypeVisitorTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/Visitors/ByteArrayTypeVisitorTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/Visitors/ByteArrayTypeVisitorTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/Visitors/ByteArrayTypeVisitorTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.WebJobs.Extensions.OpenApi.Core.Tests/Visitors/ByteArrayTypeVisitorTests.cs
Outdated
Show resolved
Hide resolved
...rosoft.Azure.WebJobs.Extensions.OpenApi.TestApp/Get_ApplicationJson_ByteArray_HttpTrigger.cs
Outdated
Show resolved
Hide resolved
...osoft.Azure.WebJobs.Extensions.OpenApi.Document.Tests/Get_ApplicationJson_ByteArray_Tests.cs
Outdated
Show resolved
Hide resolved
This will also fix #97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you also change this as well?
...tegration/Microsoft.Azure.WebJobs.Extensions.OpenApi.TestApp/Models/SingleByteArrayObject.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: poo <poo1994@hanmail.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Can you add more tests for the request body?
src/Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Visitors/ByteArrayTypeVisotor.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: poo <poo1994@hanmail.net>
Signed-off-by: poo <poo1994@hanmail.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add more integration test codes for the request body taking the byte array!
Signed-off-by: poo <poo1994@hanmail.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution!
Now, this extension supports many content types including:
|
Does this allow to set "format: binary" somehow? |
@AllTaken I would like to know too, my endpoint returns a pdf file and base64 format does not make any sense in this case |
related issue : #96, #143, #136
Supports byte array type. I also added unit and integrated tests.
overview: