Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Task #3 Test Code #412

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Add Task #3 Test Code #412

merged 2 commits into from
Apr 10, 2022

Conversation

CistusF
Copy link
Contributor

@CistusF CistusF commented Apr 10, 2022

ForceHttps Test

When OpenApi__ForceHttps is true, Server's url should be return https.

@ghost
Copy link

ghost commented Apr 10, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

justinyoo
justinyoo requested changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vendettadelsangue Thanks for your PR! I left some comments on it. Please take a look and update your PR.

...WebJobs.Extensions.OpenApi.Document.Tests/Configurations/OpenApiConfigurationOptionsTests.cs Outdated Show resolved Hide resolved
@CistusF CistusF requested a review from justinyoo April 10, 2022 04:28
justinyoo
justinyoo approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@justinyoo justinyoo merged commit d76c9e0 into Azure:main Apr 10, 2022
@justinyoo justinyoo added enhancement New feature or request oca-pr For participants from OSS Contribution Academy oca-issue For participants from OSS Contribution Academy labels Apr 10, 2022
jackbatzner pushed a commit to jackbatzner/azure-functions-openapi-extension that referenced this pull request May 6, 2022
@CistusF @jackbatzner
Add Task Azure#3 Test Code (Azure#412)
5d6f195
Derich367 pushed a commit to Derich367/azure-functions-openapi-extension that referenced this pull request Aug 31, 2022
@CistusF @Derich367
Add Task Azure#3 Test Code (Azure#412)
ff80632
Derich367 pushed a commit to Derich367/azure-functions-openapi-extension that referenced this pull request Jan 30, 2023
@CistusF @Derich367
Add Task Azure#3 Test Code (Azure#412)
d17e8db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinyoo justinyoo justinyoo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request oca-issue For participants from OSS Contribution Academy oca-pr For participants from OSS Contribution Academy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CistusF @justinyoo