Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'JsonObject.ConvertFromJson' to serialize JSON binding input #83

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Use 'JsonObject.ConvertFromJson' to serialize JSON binding input #83

merged 3 commits into from
Oct 26, 2018

Conversation

daxian-dbw
Copy link
Contributor

There are 2 changes here:

  1. Use 'JsonObject.ConvertFromJson' to serialize JSON binding input. We have to use reflection because the reference assemblies are missing in our SDK NuGet packages.
  2. Check for PSObject in our ToTypedData method, so that it handles wrapped objects properly.

TylerLeonhardt
TylerLeonhardt reviewed Oct 25, 2018
View reviewed changes
src/Utility/TypeExtensions.cs Show resolved Hide resolved
src/Utility/TypeExtensions.cs Show resolved Hide resolved
test/Utility/TypeExtensionsTests.cs Outdated Show resolved Hide resolved
test/Utility/TypeExtensionsTests.cs Outdated Show resolved Hide resolved
TylerLeonhardt
TylerLeonhardt approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TylerLeonhardt TylerLeonhardt mentioned this pull request Oct 26, 2018
Closed
9 tasks
@daxian-dbw daxian-dbw merged commit 8a0c316 into dev Oct 26, 2018
@daxian-dbw daxian-dbw deleted the json branch October 26, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daxian-dbw @TylerLeonhardt