fix(iot-service): Fix Message disposal behavior #1629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
Message
class on the service client contained a reference to the actualAmqpMessage
which is sent whenSentAsync()
was called. Since theAmqpMessage
is disposed after each Send attempt, resending the same IoT Hub message (on network failure etc) would result in us attempting to resend the same disposed Amqp message, resulting in anObjectDisposedException
.This PR removes the AmqpMessage from being a property of IoT Hub message, resulting in us being able to manage their lifetimes independently.
Is is very surprising however that no one has reported this issue yet. With our current code, if you attempt to resend the same message instance multiple times, you will always get an
ObjectDisposedException
.You can use the sample here to test this behavior (simulate network disconnect to have the sdk resend the same Message multiple times).
Even this fails:
Fix for #1638