Fix hub service client query paging, and change device clean-up #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
drwill-ms
commented
Oct 10, 2022
drwill-ms
commented
Oct 10, 2022
iothub/service/samples/how to guides/CleanupDevicesSample/CleanupDevicesSample.cs
Show resolved
Hide resolved
drwill-ms
commented
Oct 10, 2022
drwill-ms
commented
Oct 10, 2022
drwill-ms
force-pushed
the
drwill/paging-and-cleanup
branch
3 times, most recently
from
a3bcd4f
to
adb29a3
Compare
timtay-microsoft
approved these changes
Oct 10, 2022
abhipsaMisra
approved these changes
Oct 10, 2022
drwill-ms
force-pushed
the
drwill/paging-and-cleanup
branch
from
adb29a3
to
e849e34
Compare
timtay-microsoft
requested changes
Oct 10, 2022
There was a problem hiding this comment.
I'm adding a test for iterating by item over multiple pages and I'm seeing a single result returned multiple times. Let me rework the query fix for you a bit before you merge this
edit: Here's the query fix: #2842
edit 2: Fix is merged, so this looks good to me now
drwill-ms
commented
Oct 10, 2022
iothub/service/samples/how to guides/CleanupDevicesSample/CleanupDevicesSample.cs
Show resolved
Hide resolved
drwill-ms
force-pushed
the
drwill/paging-and-cleanup
branch
from
e849e34
to
66fe2f9
Compare
timtay-microsoft
approved these changes
Oct 10, 2022
patilsnr
approved these changes
Oct 10, 2022
drwill-ms
force-pushed
the
drwill/paging-and-cleanup
branch
from
3c5259a
to
ad16d0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devices clean-up broken due to 2 bugs, one in query paging, the other in the clean-up app.
Also simplified clean-up to work on an exclusion list for deletion instead of an inclusion list for deletion.