Mean time recovery #897
Merged
Mean time recovery #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoDaMa
force-pushed
the
mean_time_recovery
branch
from
a24f68a
to
67d6365
Compare
YoDaMa
force-pushed
the
mean_time_recovery
branch
from
5b22fe2
to
e9e2fb6
Compare
YoDaMa
force-pushed
the
mean_time_recovery
branch
from
e9e2fb6
to
84bae55
Compare
| // }); | ||
| // }, 10000); | ||
| // } | ||
| // }) |
There was a problem hiding this comment.
You wanted this commented out?
| // debug('Message sent successfully') | ||
| // } | ||
| // }) | ||
| // }, 2000); |
|
|
||
| function wait (ms) { | ||
| return new Promise ((resolve, reject) => { | ||
| setTimeout(resolve, ms); |
There was a problem hiding this comment.
Why did we switch to 4 char indent?
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC", |
| }, 5000); | ||
| }); // wait for 1 seconds | ||
| debug('killing childServer') | ||
| childServer.kill(); |
There was a problem hiding this comment.
Seriously. This looks creepy. Can we do better?
There was a problem hiding this comment.
lol sorry this is just the nomenclature instead of Master/Slave
|
Overall comment for the MTR. For the overall scheme about what is going on and how each part works is not documented very well. Internally to each piece should be better documented about what it's individually trying to do to accomplish the overall task. A much more extensive readme covering would be nice. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run node-canary |
|
No pipelines are associated with this pull request. |
|
/azp run horton-node-gate |
|
No pipelines are associated with this pull request. |
|
/azp run node-canary |
|
No pipelines are associated with this pull request. |
added 2 commits
October 7, 2020 14:23
…iot-sdk-node into mean_time_recovery
|
/azp run node-canary |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devdocfolder and added or modified requirements.Reference/Link to the issue solved with this PR (if any)
Description of the problem
Description of the solution