-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #925 added setOption in case of fileUploadClient #926
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
thanks for the contribution @abossard! can you please add a test for this condition? It would look very similar to the following test in describe('#setOptions', function () {
/*Tests_SRS_NODE_DEVICE_BLOB_UPLOAD_CLIENT_99_011: [`setOptions` shall set `fileUploadApi` options.]*/
it('sets file upload API options', function () {
var fakeOptions = '__FAKE_OPTIONS__';
var fakeFileUpload = new FakeFileUploadApi();
var client = new BlobUploadClient(fakeConfig, fakeFileUpload, null);
client.setOptions(fakeOptions);
assert.isTrue(fakeFileUpload.setOptions.calledWith(fakeOptions));
});
}); |
Hi @YoDaMa thanks for pointing it out. I added the required test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Checklist
devdoc
folder and added or modified requirements.Reference/Link to the issue solved with this PR (if any)
#925
Description of the problem
Pass the options also to the file upload client
Description of the solution
Checked if there is a fileUploadClient in use, and if so, the options are added to it.