Fixes 500 errors in Direct Batch Send, and upgrades httpclient to 5.2 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstr
reviewed
Feb 10, 2023
jessHuh
approved these changes
Feb 10, 2023
marstr
approved these changes
Feb 10, 2023
This was
linked to
issues
Feb 10, 2023
This was referenced Feb 10, 2023
[BUG] sendDirectNotification for batch of devices is returning 500 status for FCM notifications
#150
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things to consider before you submit the PR:
Description
This PR fixes the bug #150 in Direct Batch Send where the Content Type boundary was not being added on the request that's sent to ANH.
This PR also upgrades the dependencies httpclient, and httpcore to 5.2 to fix the issue #136 where we throw NoClassDefFoundError due to a mismatch in versions of our internal dependencies.
Related PRs or issues
#150
#136