Enabling GPv2 in powershell #24880
Merged
Enabling GPv2 in powershell #24880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.Compute
️✔️Az.EventHub
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.Sql
️✔️Az.Storage
|
YanaXu
reviewed
May 11, 2024
| /// Gets or sets whether or not this is a GPv2 variant of General Purpose edition. | ||
| /// </summary> | ||
| [Parameter(Mandatory = false, HelpMessage = "Whether or not this is a GPv2 variant of General Purpose edition.")] | ||
| public bool? IsGeneralPurposeV2 { get; set; } |
There was a problem hiding this comment.
better to add tests for added parameters and record the tests.
|
Hi @Aleksand4rZivanovic, please fix the CI errors. FYI, the next major release code complete date is 05/13. |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
Hi @Aleksand4rZivanovic any updates? If this pr is targeting current release, please add test cases as suggested. |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
VeryEarly
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
IsGeneralPurposeV2andStorageIOpsparameters toNew-AzSqlInstance,Set-AzSqlInstanceto enable the creation of GPv2 instances.Also edited some autocomplete options - removed gen4 and added gen8.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.